Bugs/reports

Solaire

@AnthonySmith said:

@Solaire said:
Do you have any PHP cache enabled?

Nope, I have an Nginx+Apache hybrid setup so I can use the required htaccess files for vanilla to actually work though, but i doubt that would be the issue.

Here's the complete, modified, class.thankfulpeople.plugin.php https://pastebin.com/RJf9Dmub.
If you want to make sure the function is actually being hit, put an echo followed by a die (i.e. echo "HITT"; die;).

InceptionHosting

@Solaire said:

@AnthonySmith said:

@Solaire said:
Do you have any PHP cache enabled?

Nope, I have an Nginx+Apache hybrid setup so I can use the required htaccess files for vanilla to actually work though, but i doubt that would be the issue.

Here's the complete, modified, class.thankfulpeople.plugin.php https://pastebin.com/RJf9Dmub.
If you want to make sure the function is actually being hit, put an echo followed by a die (i.e. echo "HITT"; die;).

Replaced, sorry but could you explain that last part to me like I am 5 or 70 years old? where specifically do I put that?

Solaire

@AnthonySmith said:

@Solaire said:

@AnthonySmith said:

@Solaire said:
Do you have any PHP cache enabled?

Nope, I have an Nginx+Apache hybrid setup so I can use the required htaccess files for vanilla to actually work though, but i doubt that would be the issue.

Here's the complete, modified, class.thankfulpeople.plugin.php https://pastebin.com/RJf9Dmub.
If you want to make sure the function is actually being hit, put an echo followed by a die (i.e. echo "HITT"; die;).

Replaced, sorry but could you explain that last part to me like I am 5 or 70 years old? where specifically do I put that?

You'd put that in front of the code block you adapted. That said, since I changed the "Thanks" thingy I reckon it's not a PHP cache issue. Is your plugin in "plugins/ThankfulPeople"?

InceptionHosting

@Solaire said:

@AnthonySmith said:

@Solaire said:

@AnthonySmith said:

@Solaire said:
Do you have any PHP cache enabled?

Nope, I have an Nginx+Apache hybrid setup so I can use the required htaccess files for vanilla to actually work though, but i doubt that would be the issue.

Here's the complete, modified, class.thankfulpeople.plugin.php https://pastebin.com/RJf9Dmub.
If you want to make sure the function is actually being hit, put an echo followed by a die (i.e. echo "HITT"; die;).

Replaced, sorry but could you explain that last part to me like I am 5 or 70 years old? where specifically do I put that?

You'd put that in front of the code block you adapted. That said, since I changed the "Thanks" thingy I reckon it's not a PHP cache issue. Is your plugin in "plugins/ThankfulPeople"?

Its /plugins/ThankfulPeople2/

From: https://open.vanillaforums.com/addon/thankfulpeople2-plugin

Solaire

@AnthonySmith said:

@Solaire said:

@AnthonySmith said:

@Solaire said:

@AnthonySmith said:

@Solaire said:
Do you have any PHP cache enabled?

Nope, I have an Nginx+Apache hybrid setup so I can use the required htaccess files for vanilla to actually work though, but i doubt that would be the issue.

Here's the complete, modified, class.thankfulpeople.plugin.php https://pastebin.com/RJf9Dmub.
If you want to make sure the function is actually being hit, put an echo followed by a die (i.e. echo "HITT"; die;).

Replaced, sorry but could you explain that last part to me like I am 5 or 70 years old? where specifically do I put that?

You'd put that in front of the code block you adapted. That said, since I changed the "Thanks" thingy I reckon it's not a PHP cache issue. Is your plugin in "plugins/ThankfulPeople"?

Its /plugins/ThankfulPeople2/

Figured. Please adjust the "class.thankfulpeople.plugin.php" accordingly (note the 2 at the end):

        $Sender->addJsFile('jquery.expander.js', 'plugins/ThankfulPeople2');
        $Sender->addCssFile('thankfulpeople.css', 'plugins/ThankfulPeople2');
        $Sender->addJsFile('thankfulpeople.functions.js', 'plugins/ThankfulPeople2');

Also, sorry for the crappy "Thanks" link right now. If you have an older version, please restore from there and apply the code above. Else, comment line 161 and 169 and uncomment lines 160 and 168

InceptionHosting

@Solaire said:

@AnthonySmith said:

@Solaire said:

@AnthonySmith said:

@Solaire said:

@AnthonySmith said:

@Solaire said:
Do you have any PHP cache enabled?

Nope, I have an Nginx+Apache hybrid setup so I can use the required htaccess files for vanilla to actually work though, but i doubt that would be the issue.

Here's the complete, modified, class.thankfulpeople.plugin.php https://pastebin.com/RJf9Dmub.
If you want to make sure the function is actually being hit, put an echo followed by a die (i.e. echo "HITT"; die;).

Replaced, sorry but could you explain that last part to me like I am 5 or 70 years old? where specifically do I put that?

You'd put that in front of the code block you adapted. That said, since I changed the "Thanks" thingy I reckon it's not a PHP cache issue. Is your plugin in "plugins/ThankfulPeople"?

Its /plugins/ThankfulPeople2/

Figured. Please adjust the "class.thankfulpeople.plugin.php" accordingly (note the 2 at the end):

      $Sender->addJsFile('jquery.expander.js', 'plugins/ThankfulPeople2');
      $Sender->addCssFile('thankfulpeople.css', 'plugins/ThankfulPeople2');
      $Sender->addJsFile('thankfulpeople.functions.js', 'plugins/ThankfulPeople2');

Also, sorry for the crappy "Thanks" link right now. If you have an older version, please restore from there and apply the code above. Else, comment line 161 and 169 and uncomment lines 160 and 168

Back in business, I guess unthank is not so imprtant right now. happy days, appreciate the assistance!

InceptionHosting

@Ympker you can thank without reload now thanks to @Solaire

poisson

Emoji fixed after a Shift+refresh. Thanks working properly and doesn't jump up anymore, either on my computer or mobile. Thanks @Solaire for the help!

InceptionHosting

The temptation to change "Thanked by :" to "Amitz? :" is overwhelming

Solaire

@AnthonySmith said:
Back in business, I guess unthank is not so imprtant right now. happy days, appreciate the assistance!

You're most welcome . Unthank is a setting apparently (according to the README):

$Configuration['Plugins']['ThankfulPeople']['AllowTakeBack'] = true;

Should go in conf/config.php I guess.

InceptionHosting

so it is..

Ympker

I can't really post an image based on an url using mobile. There seems to not exist an "upload/submit" button.

Ympker

@AnthonySmith said:
@Ympker you can thank without reload now thanks to @Solaire

Awesome!

InceptionHosting

@Ympker said:
I can't really post an image based on an url using mobile. There seems to not exist an "upload/submit" button.

I still use a samsung galaxy S2... I wont be troubleshooting that one any time soon haha.
Maybe the ipad in moble view will work to take a look.

Solaire

@AnthonySmith said:

@Ympker said:
I can't really post an image based on an url using mobile. There seems to not exist an "upload/submit" button.

I still use a samsung galaxy S2... I wont be troubleshooting that one any time soon haha.
Maybe the ipad in moble view will work to take a look.

Chrome can emulate any sort of device . I can have a look later.

poisson

@AnthonySmith said:
I still use a samsung galaxy S2... I wont be troubleshooting that one any time soon haha.
Maybe the ipad in moble view will work to take a look.

No kidding..

vimalware

There seems to be lots of unnecessary vertical space, when text wraps around in the comment editor.(mobile Firefox on Android)
This could do with tweaking, to be able to distinguish between user-inserted newlines vs wraparounds.

InceptionHosting

@vimalware said:
There seems to be lots of unnecessary vertical space, when text wraps around in the comment editor.(mobile Firefox on Android)
This could do with tweaking, to be able to distinguish between user-inserted newlines vs wraparounds.

Yes I noticed that too, the plan is to see if the community is viable, has any life blood beyond the first 30 days, take stock of things, start monetizing in 2020, use proceeds to pay for development work to be done, something that LET never did despite the obvious requirements.

So small annoyances like this wont be made worse by me just tinkering.

InceptionHosting

Turns out user driven theme switching is not so simple, I will pop "user CSS selector options" on the long term dev/features list.

poisson

I think the mobile experience is quite acceptable and we can get a pro to look at it a little later. I am confident this will live beyond 30 days!

InceptionHosting

@poisson said:
I think the mobile experience is quite acceptable and we can get a pro to look at it a little later. I am confident this will live beyond 30 days!

The whole thing could be tightened up a bit in almost every area in terms of layout as @Brendan suggested.

AlwaysSkint

Don't go dark by default. If you do, enforce CAPS and make the text pale green, then it'll be truly Dragon 32 retro.
There's a very good reason why Kindle use black on white.

Amitz

Thanks for all the efforts!

ITLabs

@Ympker said:
I can't really post an image based on an url using mobile. There seems to not exist an "upload/submit" button.

Yep, same problem here with Galaxy S8 + Android.

poisson

@ITLabs said:

@Ympker said:
I can't really post an image based on an url using mobile. There seems to not exist an "upload/submit" button.

Yep, same problem here with Galaxy S8 + Android.

Just copy the markdown code below and change the URL for now:

![](https://domain. com/filename.jpg)

mikho

I made this for the old forum
https://github.com/mikho/autosinkincategory
Not sure if it would work on this version of vanilla. It did work on the test-version I installed to create it.

tgl

I can't type Amitz!

Body is 5 characters too short.

InceptionHosting

@mikho said:
I made this for the old forum
https://github.com/mikho/autosinkincategory
Not sure if it would work on this version of vanilla. It did work on the test-version I installed to create it.

I might use it for Rants, although I have to say the offers not sinking on LET (By happy accident) was not really a bad thing as it turned out.

Also I have set this one up whereby hosts can essentially moderate/sink/unsink/close their own offer threads.

mikho

@AnthonySmith said:

@mikho said:
I made this for the old forum
https://github.com/mikho/autosinkincategory
Not sure if it would work on this version of vanilla. It did work on the test-version I installed to create it.

I might use it for Rants, although I have to say the offers not sinking on LET (By happy accident) was not really a bad thing as it turned out.

Also I have set this one up whereby hosts can essentially moderate/sink/unsink/close their own offer threads.

use it, abuse it or even forget all about it

mikho

request: group membership besides the username
Makes it easier to see who are Providers without visiting their profile